Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with: https://github.com/ClickHouse/control-plane/issues/9726
Helps with: #422
See: #455
There were several issues with the Grid in Firefox. This PR addresses three of them:
The fixes:
if
statement.event.scrollWidth
. For some reason, in Firefox, this width was being calculated based on the previous width. This led to an exponential growth in Firefox when increasing the size of a header - the previous width would be used in the new width calculation, which would then be used in the next width calculation, which caused the right scroll bar to expand very quickly. This was fixed by calculating the width based onevent.clientWidth
, rather thanscrollWidth
.:active
pseudo class, so the width calculation was incorrect. This was fixed by keeping track of theactive
state in React based on mouse presses and releases, and passing that value intostyledComponents
There was also an a11y fix for
Scrollable region must have keyboard access
New behavior in Firefox
Screen.Recording.2024-07-26.at.11.30.12.AM.mov
New behavior in Chrome
Screen.Recording.2024-07-26.at.11.30.50.AM.mov