Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Panel types #466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Export Panel types #466

wants to merge 2 commits into from

Conversation

Firefds
Copy link
Contributor

@Firefds Firefds commented Aug 22, 2024

No description provided.

@Firefds Firefds self-assigned this Aug 22, 2024
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 11:27pm

@@ -0,0 +1,3 @@
export type PanelPadding = "none" | "xs" | "sm" | "md" | "lg" | "xl";
export type PanelColor = "default" | "muted" | "transparent";
export type PanelRadii = "none" | "sm" | "md" | "lg";
Copy link
Collaborator

@fneves fneves Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these come from the Theme and are centralised. These should not be specified here.
They should be common to all components that use sizing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Firefds Why are we exporting these?
Where are we using this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vineethasok I also had the need to use these types before, whenever we are trying to specify something on a variable and not inputting them directly in the component.
For one reason or another this seems to be required to be exported from ClickUI.

These should be centralised and exported.

@Firefds one way I was able to deal without the import of the specific type in my code was to specify something like PanelProps['color']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants