Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add border prop to Container #479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add border prop to Container #479

wants to merge 1 commit into from

Conversation

Kinzeng
Copy link
Contributor

@Kinzeng Kinzeng commented Sep 16, 2024

No description provided.

@Kinzeng Kinzeng self-assigned this Sep 16, 2024
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:49pm

@gjones
Copy link
Collaborator

gjones commented Sep 16, 2024

Hmm I don't know about this, until now we've said that the container is for applying layouts only, an invisible element that controls the positioning of other components, so we haven't added borders, shadows, background colours etc. @vineethasok thoughts?

@vineethasok
Copy link
Collaborator

@Kinzeng @gjones I'm also against this
Since we have panel I don't think we should add these to containers

@gjones
Copy link
Collaborator

gjones commented Dec 12, 2024

Agreed, let's close this one and adjust panel if we feel there is anything missing from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants