Fix: respect defaultValue in Select and MultiSelect #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently,
defaultValue
inSelect
andMultiSelect
doesn't work. The reason is the effect that tracks updates of the value prop. It runs on mount as well, clearing the state with selected values that should contain default value.What
useUpdateEffect
, that works exactly ascomponentDidUpdate
in classical component lifecycle, i.e. runs every update, but not on the first rendervalue
props update, changeduseEffect
inSelect
andMultiSelect
touseUpdateEffect
defaultValue
with test cases