Skip to content

extend toast to allow passing props to toast root and allow customization #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

vineethasok
Copy link
Collaborator

No description provided.

@vineethasok vineethasok requested review from serdec and Copilot July 1, 2025 07:49
@vineethasok vineethasok self-assigned this Jul 1, 2025
Copy link

vercel bot commented Jul 1, 2025

You must have Developer access to commit code to ClickHouse on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Toast component to allow passing additional props to the underlying ToastRoot, offering greater customization.

  • Extends the ToastProps interface by omitting the original "type" property and adding a new "toastType" prop.
  • Introduces a default value for "toastType" and passes additional props via the spread operator to ToastRoot.
Comments suppressed due to low confidence (1)

src/components/Toast/Toast.tsx:19

  • [nitpick] Consider aligning the naming between 'type' (used for icon logic) and 'toastType' (passed to ToastRoot) to avoid potential confusion; a more descriptive name for one of these props might improve clarity.
  toastType?: "foreground" | "background";

@vineethasok vineethasok merged commit bb07326 into main Jul 1, 2025
3 of 5 checks passed
@vineethasok vineethasok deleted the toast-optimization branch July 1, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants