fix(FileUpload): update styling #679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the visual presentation and state management of FileUpload components by repositioning progress bars to appear directly beneath file names and enhancing UI consistency.
- Restructured layout to display progress bars under file names instead of in separate containers
- Enhanced state management to prevent progress and success states from conflicting
- Replaced inline styles with styled components and improved error state styling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/FileUpload/FileUpload.tsx | Restructured file info layout, moved progress bar positioning, and improved state-based rendering logic |
| src/components/FileUpload/FileMultiUpload.tsx | Applied consistent layout changes and state management improvements to match FileUpload component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hoorayimhelping
approved these changes
Oct 15, 2025
| <FileDetails> | ||
| <FileName>{truncateFilename(file.name)}</FileName> | ||
| {file.status === "uploading" && ( | ||
| <FileUploadDescription>{file.progress}%</FileUploadDescription> |
There was a problem hiding this comment.
I think we should probably use Intl.NumberFormat with a style of percent, just because it gives us more future proofing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved progress bar positioning to appear directly under file name text for both
FileUploadandFileMultiUploadcomponents. Aligns with changes @crisalbu gave me. It is backward compatible so no concerns for control plane usages.