Merge pull request #404 from dngrudin/check_for_sending_errors

Changed error detection check when sending data via socket
ClickHouse · Dec 16, 2024 · 2a49a25 · 2a49a25
2 parents d242cc8 + bfd5a07
commit 2a49a25
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/clickhouse/base/socket.cpp b/clickhouse/base/socket.cpp
@@ -457,11 +457,12 @@ size_t SocketOutput::DoWrite(const void* data, size_t len) {
     static const int flags = 0;
 #endif
 
-    if (::send(s_, (const char*)data, (int)len, flags) != (int)len) {
+    const ssize_t ret = ::send(s_, (const char*)data, (int)len, flags);
+    if (ret < 0) {
         throw std::system_error(getSocketErrorCode(), getErrorCategory(), "fail to send " + std::to_string(len) + " bytes of data");
     }
 
-    return len;
+    return (size_t)ret;
 }