-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parameterized syntax, just syntax-sugar #260
Conversation
Closing to re-open and re-trigger CI/CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires more test cases, e.g. when there is an '?'
already present in query string, like this:
SELECT 'hello!?'
I suggest utilizing existing CH features for that: For developers, that means we'd have to either
Notes to myself on how to implement later on CH side: |
Update: it looks like CH already supports setting parameters via native TCP protocol, we just need to update protocol version up to So we need to add following features one by one:
So yeah, |
ok |
Now clickhouse-cpp supports parameterized syntax, and the placeholder should be ? .
It is just syntax-sugar, all replacing happens on the client side
Any document about clickhouse-server prepare statement?
@Enmk