Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out prep-from-local, prep-from-master commands into .sh files #2951

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

Blargian
Copy link
Member

Summary

prep-from-local and prep-from-master commands are difficult to modify or maintain if needed in their current form.
This PR separates out those commands into their own .sh files, adds comments and some basic error handling.

Checklist

@gingerwizard
Copy link
Contributor

@Blargian i want to rework this completely, lets discuss.

@Blargian
Copy link
Member Author

@gingerwizard I'm going to work on build script improvements today, but would like to merge this first #2951 (separates out the prep-from-local and prep-from-master scripts to their own files)

Let's improve incrementally

@gingerwizard
Copy link
Contributor

@Blargian lets merge this, can you fix the package.json - exclude it from the PR not related

@gingerwizard gingerwizard merged commit 5956b43 into ClickHouse:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants