-
Notifications
You must be signed in to change notification settings - Fork 388
Functions: start generating string replacement functions #4583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new "String Replacement" function category to the autogeneration script and updates source/destination file arrays to include related markdown generation.
- Adds category entry "String Replacement" to FUNCTION_CATEGORIES
- Adds source file name string_replacement-functions.md
- Adds destination path string-replace-functions.md (inconsistent with source/category naming)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
"time_series-functions.md" | ||
"other-functions.md" | ||
"time_window-functions.md" | ||
"string_replacement-functions.md" |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.
"string_replacement-functions.md" | |
"string_replace-functions.md" |
Copilot uses AI. Check for mistakes.
"docs/sql-reference/functions/time-series-functions.md" | ||
"docs/sql-reference/functions/other-functions.md" | ||
"docs/sql-reference/functions/time-window-functions.md" | ||
"docs/sql-reference/functions/string-replace-functions.md" |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.
Copilot uses AI. Check for mistakes.
Summary
Adds a new "String Replacement" function category to the autogeneration script and updates source/destination file arrays to include related markdown generation.
Adds category entry "String Replacement" to FUNCTION_CATEGORIES
Adds source file name string_replacement-functions.md
Adds destination path string-replace-functions.md (inconsistent with source/category naming)
Checklist