Skip to content

Conversation

Blargian
Copy link
Member

@Blargian Blargian commented Oct 16, 2025

Summary

Adds a new "String Replacement" function category to the autogeneration script and updates source/destination file arrays to include related markdown generation.

Adds category entry "String Replacement" to FUNCTION_CATEGORIES
Adds source file name string_replacement-functions.md
Adds destination path string-replace-functions.md (inconsistent with source/category naming)

Checklist

@Blargian Blargian requested a review from a team as a code owner October 16, 2025 13:20
@Blargian Blargian requested a review from Copilot October 16, 2025 13:20
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clickhouse-docs Ready Ready Preview Comment Oct 16, 2025 4:17pm
clickhouse-docs-jp Building Building Preview Comment Oct 16, 2025 4:17pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
clickhouse-docs-ru Ignored Ignored Preview Oct 16, 2025 4:17pm
clickhouse-docs-zh Ignored Ignored Preview Oct 16, 2025 4:17pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new "String Replacement" function category to the autogeneration script and updates source/destination file arrays to include related markdown generation.

  • Adds category entry "String Replacement" to FUNCTION_CATEGORIES
  • Adds source file name string_replacement-functions.md
  • Adds destination path string-replace-functions.md (inconsistent with source/category naming)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"time_series-functions.md"
"other-functions.md"
"time_window-functions.md"
"string_replacement-functions.md"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.

Suggested change
"string_replacement-functions.md"
"string_replace-functions.md"

Copilot uses AI. Check for mistakes.

"docs/sql-reference/functions/time-series-functions.md"
"docs/sql-reference/functions/other-functions.md"
"docs/sql-reference/functions/time-window-functions.md"
"docs/sql-reference/functions/string-replace-functions.md"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming between source (string_replacement) and destination (string-replace) plus mismatch between 'replacement' vs 'replace'. This likely breaks the expected index-based mapping or results in a missing destination file. Recommend standardizing to either 'string_replacement-functions.md' / 'string-replacement-functions.md' (matching existing pattern of underscore in source, hyphen in dest while keeping the same stem) or 'string_replace-functions.md' / 'string-replace-functions.md', but keep the stem identical in both arrays.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant