Closing Issue #1373 #1509
Merged
Closing Issue #1373 #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
Should it close #1373 ? Could you add a description to the PR title? |
Yes it should adding in the description |
mshustov
approved these changes
Jan 2, 2024
| @@ -326,6 +326,7 @@ public void addBatch() throws SQLException { | |||
|
|
|||
| ClickHouseDataProcessor processor = getDataProcessor(stream, null, columns); | |||
| int nullAsDefault = getNullAsDefault(); | |||
| // validate the values before the actual write into the processor | |||
There was a problem hiding this comment.
nit: Can we move it into a separate method to make the comment unnecessary?
| ps.setInt(2, 10); | ||
| ps.setString( 3, count == 2 ? null : "--------"); | ||
| ps.addBatch(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Can the catch clause be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Will close Issue #1373
Fix the case while we have an error in addBatch method
Checklist
Delete items not relevant to your PR: