Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests against LATEST to address suspicious low cardinality array check. #1562

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix integration tests against LATEST to address suspicious low cardinality array check. #1562

merged 2 commits into from
Mar 19, 2024

Conversation

chernser
Copy link
Contributor

Summary

There is a fix in CH > 24.2 that does check for columns marked as LowCardinality in nested types (Array/Tuple/Map).
See ClickHouse/ClickHouse#59385

Checklist

Delete items not relevant to your PR:

  • [X ] Unit and integration tests covering the common scenarios were added

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mshustov mshustov requested a review from mzitnik March 15, 2024 19:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser requested a review from mzitnik March 18, 2024 19:24
@chernser chernser merged commit 27e3168 into main Mar 19, 2024
58 of 59 checks passed
@chernser chernser deleted the fix-tests-suspicious-low-cardinality branch April 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chernser @CLAassistant @mzitnik