No-op flags #2030
No-op flags #2030
Conversation
| @@ -118,14 +118,22 @@ public PreparedStatement prepareStatement(String sql) throws SQLException { | |||
| @Override | |||
| public CallableStatement prepareCall(String sql) throws SQLException { | |||
| checkOpen(); | |||
| throw new SQLFeatureNotSupportedException("CallableStatement not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED); | |||
| if (!config.isIgnoreUnsupportedRequests()) { | |||
There was a problem hiding this comment.
I would think this is totally valid exception because if this is called then NPE will be thrown anyway.
In most cases we can ignore parameters, but not a whole functionality.
| throw new SQLFeatureNotSupportedException("nativeSQL not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED); | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
may be return the same sql? + javadoc that it is not implemented according to the spec if flag is true
| throw new SQLFeatureNotSupportedException("CallableStatement not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED); | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
the same - this is whole functionality and it will be NPE anyway. so Exception should be thrown all the time
| throw new SQLFeatureNotSupportedException("getTypeMap not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED); | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
This kind of missing functionality. I would return an empty map at least to not cause NPE.
But we need to create an issue and fill this properly
| } | ||
|
|
||
| @Override | ||
| public int getNetworkTimeout() throws SQLException { | ||
| //TODO: Should this be supported? | ||
| throw new SQLFeatureNotSupportedException("getNetworkTimeout not supported", ExceptionUtils.SQL_STATE_FEATURE_NOT_SUPPORTED); | ||
| if (!config.isIgnoreUnsupportedRequests()) { |
There was a problem hiding this comment.
I mean it may be a useful timeout - we should take it from client.
|
Summary
We should obey the no-op flag for unsupported features where possible.
Checklist
Delete items not relevant to your PR: