[jdbc-v2] Fixed closing prev result set #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
Dec 19, 2024
Paultagoras
approved these changes
Dec 19, 2024
|
slvrtrn
reviewed
Dec 19, 2024
| @@ -289,6 +301,7 @@ private boolean execute(String sql, QuerySettings settings) throws SQLException | |||
| executeQuery(sql, settings); // keep open to allow getResultSet() | |||
| return true; | |||
| } else if(type == StatementType.SET) { | |||
| executeUpdate(sql, settings); | |||
There was a problem hiding this comment.
@chernser
I don't think that we need to execute this update; the role URL setting is enough, as the HTTP interface is stateless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes closing prev. result set in
execureQuerymethod ofStatementImpl.Also fixed passing
SETqueries to server and not just handling roles staff.Checklist
Delete items not relevant to your PR: