New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup + Type Conversion #2045

Merged

Paultagoras merged 5 commits into main from type-conversion

Dec 22, 2024

+291 −293

Contributor

Paultagoras commented Dec 20, 2024 •

edited

Loading

Summary

Cleaning up methods that use columnIndex to use columnLabel instead (so that we can edit in one place)
Adding some type conversion methods for convenience in JDBC
Tweaking to use JDBCType enum rather than just the int values
Closes [jdbc-v2] getObject(Type) should try and do some type conversion #2039

Checklist

Delete items not relevant to your PR:

Closes issue
Unit and integration tests covering the common scenarios were added
A human-readable description of the changes was provided to include in CHANGELOG
For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials


          Cleanup + Type Conversion

48c153e

Paultagoras requested review from mzitnik and chernser

December 20, 2024 17:23

Paultagoras self-assigned this


          Update DataTypeTests.java

6d30ed9

chernser reviewed

View reviewed changes

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java Outdated Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java Outdated Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/test/java/com/clickhouse/jdbc/DataTypeTests.java Outdated Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/main/java/com/clickhouse/jdbc/ResultSetImpl.java Outdated Show resolved Hide resolved

chernser reviewed

View reviewed changes

jdbc-v2/src/main/java/com/clickhouse/jdbc/ResultSetImpl.java Outdated Show resolved Hide resolved


          Update JdbcUtils.java

be52a87

sonarqubecloud bot commented Dec 22, 2024

Quality Gate failed

Failed conditions
51.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud


          change-default-types

c2fa5d8

chernser approved these changes

View reviewed changes


          Update DataTypeTests.java

874249b

Paultagoras merged commit 6c2ed7b into main

1 check failed

Paultagoras deleted the type-conversion branch

December 22, 2024 02:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet