Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust roles parsing #2048

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Adjust roles parsing #2048

merged 3 commits into from
Dec 21, 2024

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Dec 20, 2024

Summary

  • Tweaks token generator to go character-by-character rather than regex (so it can account for double quotes)
  • Expands tests to add additional roles

Checklist

Delete items not relevant to your PR:

  • Closes issue
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras merged commit 9d8fb28 into main Dec 21, 2024
59 of 62 checks passed
@Paultagoras Paultagoras deleted the adjust-roles-parsing branch December 21, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants