Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc-v2] Fixed Tests #2056

Merged
merged 1 commit into from
Dec 28, 2024
Merged

[jdbc-v2] Fixed Tests #2056

merged 1 commit into from
Dec 28, 2024

Conversation

chernser
Copy link
Contributor

Summary

Checklist

Delete items not relevant to your PR:

  • Closes issue
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from mzitnik December 28, 2024 07:34
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for general knowledge why we decrease the limit number?
What are we testing here where is no assert in the test body

@chernser
Copy link
Contributor Author

Bigger number cause timeout on cloud.
But test is verifying that cancel doesn't stuck or throw exception.
we would need a better test for this.

@chernser chernser merged commit 590d334 into main Dec 28, 2024
29 of 30 checks passed
@chernser chernser deleted the fix_jdbc_tests branch December 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants