Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Removed old defaults and replaced new ones #2084

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[client-v2] Removed old defaults and replaced new ones #2084

merged 2 commits into from
Jan 14, 2025

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Jan 13, 2025 •
edited
Loading

Summary

  • Removed old defaults from builder
  • Set new default values in setDefaults

Checklist

Delete items not relevant to your PR:

  • Closes issue
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Jan 13, 2025
@chernser chernser changed the title Removed old defaults and replaced new ones [client-v2] Removed old defaults and replaced new ones Jan 13, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras merged commit 5995a7e into main Jan 14, 2025
29 of 30 checks passed
@Paultagoras Paultagoras deleted the fix-default-timeouts branch January 14, 2025 17:45
@chernser chernser mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chernser chernser chernser approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees

@Paultagoras Paultagoras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paultagoras @chernser