Expose X-ClickHouse-Summary header info
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
reviewed
Dec 6, 2023
|
|
||
| ### New features | ||
|
|
||
| - (Node.js only) `X-ClickHouse-Summary` response header is now parsed when working with `insert`/`exec`/`command` methods. |
There was a problem hiding this comment.
don't we need send_progress_in_http_headers=1 header? see https://github.com/ClickHouse/clickhouse-connect/blob/6928aed5845c944007b6bf93e806313a96a93fbc/clickhouse_connect/driver/httpclient.py#L368-L370
There was a problem hiding this comment.
Interesting, something to discuss for sure. In tests, for non-streaming operations, it works regardless.
There was a problem hiding this comment.
According to the Changelog, it should work for non-streaming operations
mshustov
reviewed
Dec 7, 2023
packages/client-common/__tests__/integration/data_types.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
summaryfield toinsert/exec/commandresult, which is parsed from theX-ClickHouse-Summaryresponse header.Node.js only. The web version seems to have some CORS limitations.
Question: shall we expose
summaryforquery, too? It is very unlikely to be correct with streaming scenarios, and for non-streaming ones, we know the number of rows anyway.Resolves #210
Checklist