Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default HTTP settings + readonly user switch #225

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Jan 26, 2024

Summary

See CHANGELOG. It is a breaking change for read-only users, but IMO necessary, as timeout issues when an LB terminates a long-running query connection are incredibly obscure, and this should at least cover AWS LB defaults.

It works similarly to how clickhouse-connect handles it (but currently does not normalize it based on the request timeout).

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • Docs will be updated if we decide to merge this.

@slvrtrn slvrtrn requested a review from mshustov January 26, 2024 22:56
CHANGELOG.md Show resolved Hide resolved

```ts
const client = createClient({
readonly: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in clickhouse, readonly has a bit different semantics: 0, 1, 2. let's align

CHANGELOG.md Show resolved Hide resolved
@slvrtrn
Copy link
Contributor Author

slvrtrn commented Jan 31, 2024

@mshustov, I updated the version, docs, and CHANGELOG, plus added an example, WDYT?

@slvrtrn slvrtrn changed the base branch from main to 0.3.0 February 29, 2024 10:28
@slvrtrn slvrtrn merged commit 5e9d773 into 0.3.0 Feb 29, 2024
23 checks passed
@slvrtrn slvrtrn deleted the default-http-settings branch February 29, 2024 10:29
@slvrtrn slvrtrn mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants