Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Nested data type #227

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Feb 11, 2024

Summary

Closes #89

It looks like the Nested data type is already supported, but the documentation says it isn't yet supported: https://clickhouse.com/docs/en/integrations/language-clients/javascript#supported-clickhouse-data-types

https://github.com/ClickHouse/clickhouse-docs/blob/d99f31aa0e8aa50085a737ca3402f09931c75b9f/docs/en/integrations/language-clients/js.md?plain=1#L739

This may lead to confusion.

I'm adding tests to prove that it does work, so I can update the status of support in the docs

Checklist

  • Unit and integration tests covering the common scenarios were added

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2024

CLA assistant check
All committers have signed the CLA.

@slvrtrn
Copy link
Contributor

slvrtrn commented Feb 11, 2024

Thanks for the contribution!

@slvrtrn slvrtrn merged commit cbc1090 into ClickHouse:main Feb 11, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Nested data type support
3 participants