Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer ResultSet type hints based on DataFormat #238

Merged
merged 18 commits into from
Mar 26, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Mar 11, 2024

Summary

Into 1.0.0. See the changelog entry. Docs will be updated accordingly.

Screencast.from.2024-03-09.08-10-26.webm

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov March 11, 2024 16:44
@slvrtrn slvrtrn mentioned this pull request Mar 12, 2024
export class ResultSet implements BaseResultSet<Stream.Readable> {
/** {@link Stream.Readable} with additional types for the `on(data)` method.
* Everything else is an exact copy from stream.d.ts */
export type StreamReadable<T> = Omit<Stream.Readable, 'on'> & {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the custom definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional types for the on(data) method.

By default, it's any there.

@slvrtrn slvrtrn merged commit 0c73398 into 1.0.0 Mar 26, 2024
27 checks passed
@slvrtrn slvrtrn deleted the result-set-types-based-on-format branch March 26, 2024 19:15
slvrtrn added a commit that referenced this pull request Mar 29, 2024
1.0.0

* Add support for URL parameters parsing (#232)
* Infer ResultSet type hints based on DataFormat (#238)
* Add SharedMergeTree Cloud tests, remove Node 16 from the CI, and add Node 21 (#234)
* Add pathname config option, revert read-only switch/default settings (#251)
* Improved performance when decoding the entire set of rows with streamable JSON formats (#253)
* Bump dev dependencies, update internal module resolution (#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants