Fix macos stacktraces for 19.x #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use backtrace function instead of unw_backtrace for OS_DARWIN Ref: 2a8967b
|
@korowa Thanks. I had two questions:
|
rschu1ze
reviewed
Mar 4, 2025
| #endif | ||
|
|
||
| #ifdef STD_EXCEPTION_HAS_STACK_TRACE | ||
| #if defined(OS_DARWIN) |
There was a problem hiding this comment.
Please add a comment here, saying that this is a ClickHouse-specific patch of LLVM + the motivation + (if possible) a reference to an issue.
Don't think so, as it's built on top of 2b214a3 which is already a ClickHouse-specific modifications
Now yes (this PR was created before just to link submodule to the commit from this repo, not from the fork) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use backtrace function instead of unw_backtrace for OS_DARWIN
Bringing back capturing exception stacktraces on MacOS (missing, presumably, after switching to ClickHouse/llvmorg-16.0.6 branch)
Ref: 2a8967b