Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependencies: Add optional viz, complete. #538

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

brews
Copy link
Member

@brews brews commented May 31, 2024

This makes geopandas and matplotlib optional dependencies under impactlab-tools[viz] as they are only used in the "visualization" submodule.

h5netcdf is also no longer a dependency as it's not something used directly by the package. Users are instead expected to install and configure whatever netcdf suite works for their system and xarray.

Making these dependencies optional hopefully lightens the burden of impactlab-tools.

Users can install everything with pip install impactlab-tools[complete].

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.04%. Comparing base (4ab6af8) to head (b91d5be).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files          13       13           
  Lines         470      470           
=======================================
  Hits          301      301           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brews brews merged commit 6bd32e5 into master May 31, 2024
5 checks passed
@brews brews deleted the dep_refactor branch May 31, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant