Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring scores #263

Closed
wants to merge 4 commits into from
Closed

Conversation

seanmajorpayne
Copy link
Member

@seanmajorpayne seanmajorpayne commented Oct 10, 2021

Fixes #267

  • Refactored for Pep-8 & Pep-287
  • Updated imports for Pep-8 (Standard Library first, 3rd party second, our app 3rd & Alphabetical for each section)
  • Replaced ALL_CAPS variables
  • Switched unnecessary self variables to function variables
  • (Fixed?) Changed localized graph to actually query the session_id instead of giving the Sessions object a quiz_uuid to query by
  • Moved test ontology creation outside of the feed & into the app config (this doesn't need to be done individually per user)
  • Added dependency injection for the class instead of declaring other classes inside
  • (Probably?) Significantly faster since this removes a pass through the ontology. Need to see test results.
  • Removed num_feed_cards variable that was being passed through 3 functions and added it directly to function where used

In a separate PR, we need to figure out if the localized graph is doing what it is supposed to do.

@seanmajorpayne seanmajorpayne linked an issue Oct 10, 2021 that may be closed by this pull request
app/feed/get_feed.py Outdated Show resolved Hide resolved
@seanmajorpayne
Copy link
Member Author

@rodriguesk Reverted feed cards based on your feedback. Ready for review.

@danmash danmash deleted the CM-871-score-nodes-refactor branch June 30, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Feed & Score Nodes
2 participants