fix: do not fire hold if a scroll is made #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunosabot
force-pushed
the
fix/hold-is-triggering-when-scrolling
branch
from
875793e
to
72f8679
Compare
|
My man! |
|
It still has an issue, when scrolling down, but the viewport is already at the bottom (or scrolling up at the top), the click is still triggered. |
|
Maybe a better way could be to remember the X/y coordinates of the initial hold, and if they are still the same after the timeout and we are still holding, we know we didn't scroll but a hold action is performed? Although I'm wondering if there isn't a standard way to do this. |
Clooos
added a commit
that referenced
this pull request
Oct 22, 2024
- [x] Separator line background color global variable - [x] Select card and select sub-buttons now supports attribute lists for climate, light and media player entities (I maybe forgot to add some, please open an issue if you want one that is missing) #665 - [x] New media player blurred background option - [x] New experimental climate card (but should works flawlessly) #398 - [x] Added a toggle in the sub-buttons editor for disabling the background color based on entity state - [x] The back button issue should be fixed in all cases #856 - [x] Fixed the sliders that where not working anymore #849 #838 - [x] Fan sliders are now set to 0 when off - [x] Slider with climate expected float #768 - [x] Do not fire hold if a scroll is made #843 by @brunosabot - [x] Minor CSS fixes - [x] Some various minor fixes - [x] Some various optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Hold action is fired too fast and prevent the scroll
What did I do: