Split specfile output for client and server #116
Conversation
keymaster.spec
Outdated
| %description | ||
| Simple utilites for checking state of ldap infrastructure | ||
| Certificate based identity system. Contains both a daemon | ||
| and a clients. |
| /usr/sbin/userdel keymaster | ||
| systemctl daemon-reload | ||
|
|
||
|
|
||
| %files |
There was a problem hiding this comment.
I think you can remove this line?
| %{_bindir}/keymaster-unlocker | ||
| /usr/lib/systemd/system/keymaster.service |
There was a problem hiding this comment.
Should these be under %files client as well? (since they are keymaster, not keymasterd)
There was a problem hiding this comment.
no, the service name is called keymaster. And is precisely what why are trying to split. Clientd do not need the systemd parts.
There was a problem hiding this comment.
Intention is not 100% clear.
If the goal is to deprecate keymaster package and create keymaster-server and keymaster-client packages, then this works. Unsure if this is intended. Approving if that is the case.
The alternative would be to remove "%package server" and all references to server in other sections. This will allow the keymaster server to continue to simply be the keymaster rpm package and create a separate package for keymaster-client.
| #%doc | ||
| %{_sbindir}/keymasterd | ||
| %{_bindir}/keymaster | ||
| %{_bindir}/keymaster-unlocker | ||
| /usr/lib/systemd/system/keymaster.service |
There was a problem hiding this comment.
If we rename the package keymaster-server, shouldn't this service file also be renamed keymaster-server.service?
Sorry, clicked the wrong thing. Should be for line 92.
|
What about the split out of |
No description provided.