Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NVD 2.0 API #230

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Migrate to NVD 2.0 API #230

merged 1 commit into from
Dec 13, 2023

Conversation

oswalpalash
Copy link
Member

Description

As noted from #224 , we need to upgrade to the NVD 2.0 API. There is a significant redesign in the way the API works, but our stuff should mostly keep working. Tested it locally and it seemed to not make major mistakes.
cc @joshbressers please test it because I know you might have more insights on this from the v1 API work.

Fixes #224

Type of change

Changes NVD Data Source from v1 of their API to v2.

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally against the copy of gsd-database.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@joshbressers joshbressers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work perfectly, thank you!

@joshbressers joshbressers merged commit f533dec into main Dec 13, 2023
4 checks passed
@joshbressers
Copy link
Collaborator

Apologies for how long this took. I truly appreciate the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NVD automation to use the V2 api
2 participants