Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walmart_scraper #1091

Closed

Conversation

DivyaVijay1234
Copy link

Description

This pull request creates the WalmartProduct class by adding detailed logging for debugging, improving error handling with specific messages for each method, verifying and matching Walmart's current structure, and ensuring robust configuration management for request headers. These changes improve the reliability and maintainability of the web scraping process, making it easier to identify and resolve issues when fetching product details, images, and customer reviews from Walmart's website.

Resolves: #969

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Screenshot 2024-06-01 005018

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.

Copy link
Member

@nikhil25803 nikhil25803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstring to your class and methods. Also document your module in dev-documentation.md.

@DivyaVijay1234
Copy link
Author

Hello @nikhil25803,
I have made the changes requested by you. Do let me know if any further changes are required.
Thank you.

@nikhil25803
Copy link
Member

I tested the endpoints, some of them are returning error and even no result at all

@DivyaVijay1234
Copy link
Author

@nikhil25803 Would you be able to give me a few examples of cases for which the code fails to yield accurate results? I will look into it and make necessary changes.
I appreciate your time and patience in this regard. Thank you.

@nikhil25803 nikhil25803 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat:Scrape from walmart
2 participants