Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Feat: Scrapping data from Indiantrekking #904 #967

Closed

Conversation

Anshika14528
Copy link
Contributor

@Anshika14528 Anshika14528 commented May 14, 2024

Description

Added indiantrekking module to give information about various treks in India.

Usages

from scrape_up import Indiantrekking

Create an instance of 'Indiantrekking' class

trek=Indiantrekking("hidden-lakes-of-kashmir")
Method Details
destination() return name of the place.
trip_fact() returns the trip duration, destination, altitude and the season good for trekking
outline_day_to_day_itinerary returns the ouline of the day to day itinerary

Resolves: [Issue Number]: #904

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@Anshika14528
Copy link
Contributor Author

@nikhil25803 sir, could you please review this pull request?

@@ -0,0 +1,68 @@
from bs4 import BeautifulSoup
from playwright.sync_api import sync_playwright
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anshika14528, can you do it without any Webkit. like sync_playwright
Use Beautiful Soup Only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil25803 sir , I have updated it to use requests module instead of sync_playwright
Can you please review it again?

@Anshika14528 Anshika14528 deleted the indiantrekking branch May 17, 2024 18:36
@Anshika14528 Anshika14528 restored the indiantrekking branch May 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants