-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Feat: Scrapping data from Indiantrekking #904 #967
fix: Feat: Scrapping data from Indiantrekking #904 #967
Conversation
@nikhil25803 sir, could you please review this pull request? |
src/scrape_up/Indiantrekking/trek.py
Outdated
@@ -0,0 +1,68 @@ | |||
from bs4 import BeautifulSoup | |||
from playwright.sync_api import sync_playwright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anshika14528, can you do it without any Webkit
. like sync_playwright
Use Beautiful Soup Only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhil25803 sir , I have updated it to use requests module instead of sync_playwright
Can you please review it again?
Description
Added indiantrekking module to give information about various treks in India.
Usages
Create an instance of 'Indiantrekking' class
destination()
trip_fact()
outline_day_to_day_itinerary
Resolves: [Issue Number]: #904
Checklist
I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.