Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT : add lichess module and update documentation #977

Merged
merged 5 commits into from
May 18, 2024

Conversation

msabry1
Copy link
Contributor

@msabry1 msabry1 commented May 15, 2024

Description

The changes made in this pull request should be briefly described.

Resolves:#954

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • [yes] Have you adhered to the repository's defined coding convention rules?
  • [yes] Have you updated the 'documentation.md' file with the method/function documentation?
  • [yes] Have you sent a message along with the result or response?
  • [yes] Have you used the try-catch technique?
  • [yes] Has the method/class been added to the documentation (md file)?

Screenshots

image


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.

@msabry1
Copy link
Contributor Author

msabry1 commented May 16, 2024

Can you review this changes @nikhil25803 ?

@nikhil25803
Copy link
Member

Hey @msabry1, the code is extremely slow. It is not able to fetch data even within 10/15 sec. Please optimize it to a certain level.

@msabry1
Copy link
Contributor Author

msabry1 commented May 16, 2024

HI @nikhil25803 you can review and see changes now

@msabry1
Copy link
Contributor Author

msabry1 commented May 17, 2024

@nikhil25803 can you rereview bro ?

@nikhil25803
Copy link
Member

Resolve the conflicts

@msabry1
Copy link
Contributor Author

msabry1 commented May 17, 2024

done solved @nikhil25803

@nikhil25803 nikhil25803 merged commit 8189ed1 into Clueless-Community:main May 18, 2024
@nikhil25803
Copy link
Member

Great work @msabry1 !!
Do not forget to

  • Share your contribution on socials and tag Clueless 🫂
  • Give this repository a star ✨
  • Follow Clueless Community on GitHub ✅

@nikhil25803 nikhil25803 added level3 gssoc GSSoC 2024 and removed under review labels May 18, 2024
@msabry1 msabry1 deleted the lichess-feature branch May 18, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC 2024 level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants