Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config class #997

Merged
merged 10 commits into from
May 17, 2024
Merged

Config class #997

merged 10 commits into from
May 17, 2024

Conversation

Siddhesh-Agarwal
Copy link
Contributor

@Siddhesh-Agarwal Siddhesh-Agarwal commented May 17, 2024

Description

  • Created a RequestConfig class that contains support for proxies, timeout and allow_redirect
  • Created corresponding get method
  • Ported existing integrations to the class and function

Resolves: #976

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@Siddhesh-Agarwal
Copy link
Contributor Author

Need to update docs

@nikhil25803 nikhil25803 merged commit 85df308 into Clueless-Community:main May 17, 2024
@nikhil25803
Copy link
Member

Great work @Siddhesh-Agarwal !!
Do not forget to

  • Share your contribution on socials and tag Clueless 🫂
  • Give this repository a star ✨
  • Follow Clueless Community on GitHub ✅

@Siddhesh-Agarwal Siddhesh-Agarwal deleted the config-class branch May 18, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC 2024 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for proxies
2 participants