Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little fixes to the prometheus sink #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oscarminus
Copy link
Contributor

@oscarminus oscarminus commented Mar 26, 2024

  1. Nvlink error counters are unsigned integers, this option was missing in the cast method
  2. Prometheus was no available sink although the code was there
  3. NVlink errors are gathered by gpu and link. The prometheus exporter did not recognize the link id and therefore only reports the last link of each gpu. For our case, the sum of all links per gpu is the interesting value. So we implement this as a seperate metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant