Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled the firewall again. #756

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enabled the firewall again. #756

wants to merge 6 commits into from

Conversation

digimer
Copy link
Member

@digimer digimer commented Oct 24, 2024

This is fully expected to fail initially.

@ylei-tsubame
Copy link
Collaborator

Please test the VNC connection from the web UI.

The VNC-to-websocket translation is done by websockify on a server's VNC port + 10000. For example, a server with VNC port 5900 should have the websockify port (listening to incoming connections) at 15900.

The port selection for the websockify instance will also jump to the next available port when the suggested one is in-use. For example, if ports 15900 and 15901 are in-use, then port 15902 will be selected as the websockify port. We shouldn't need to worry about this because there shouldn't be any known apps using ports in this area.

@digimer
Copy link
Member Author

digimer commented Oct 24, 2024

What command specifically is used to check if a port is in use and needs to be incremented? I can do the same check when opening the corresponding port.

@digimer
Copy link
Member Author

digimer commented Oct 26, 2024

retest this please

@digimer digimer changed the title Do Not Merge - Enabled the firewall again. Enabled the firewall again. Oct 26, 2024
@digimer
Copy link
Member Author

digimer commented Oct 26, 2024

This PR now passes automated testing. Manual testing now required before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants