-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INI migration guide #483
INI migration guide #483
Conversation
Nightly build for this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to account for net48 revert and merge ASAP so that we could release the update for the masses.
@MortonPL anything on that? |
It's there, see paragraph "Port custom game options" (lines 543-580). There isn't really much to do, though. |
Ah the syntax highlighting broke so I didn't notice, pardon. Then I don't have much complaints, let's address the remaining feedback from Rampa and SadPencil and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from manual line breaks and the comment below I see no issues, great job.
* Add second migration guide * Update Migration-INI.md * Add mention in the main migration guide * Update Migration-INI.md * Add extra empty lines between headers and code blocks * Reference a specific mod base commit, revert .NET 7 changes * Make large code blocks collapsible, add more descriptions * Refer to the new version as 2.11.0.0 * Mention .NET 8 binaries again * Reorder paragraphs * Enforce 80 character line width * Don't use the word "root" when referring to the game directory root * Make .NET 8 build not optional * Mention the second stage updater * Stash * Ensure that the migration guide works * Add directory tree view for executables * Remove hard line wrap --------- Co-authored-by: SadPencil <[email protected]>
* Add second migration guide * Update Migration-INI.md * Add mention in the main migration guide * Update Migration-INI.md * Add extra empty lines between headers and code blocks * Reference a specific mod base commit, revert .NET 7 changes * Make large code blocks collapsible, add more descriptions * Refer to the new version as 2.11.0.0 * Mention .NET 8 binaries again * Reorder paragraphs * Enforce 80 character line width * Don't use the word "root" when referring to the game directory root * Make .NET 8 build not optional * Mention the second stage updater * Stash * Ensure that the migration guide works * Add directory tree view for executables * Remove hard line wrap --------- Co-Authored-By: SadPencil <[email protected]>
This PR extends the migration guide with a step-by-step example INI configuration migration. It's aimed at YR modders, but most steps are applicable to any game using this client.