Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2 snake tokens #143

Merged
merged 3 commits into from
May 9, 2022
Merged

Fixes 2 snake tokens #143

merged 3 commits into from
May 9, 2022

Conversation

mainman879
Copy link
Contributor

@mainman879 mainman879 commented May 7, 2022

fixes #140 Ophiomancer didn't have an official token until now so this adds that. The snake for Hapatra Vizier of Poisons had a broken link so this also fixes that.

Cockatrice#140 Ophiomancer didn't have an official token until now so this adds that. The snake for Hapatra Vizier of Poisons had a broken link so this also fixes that.
tokens.xml Outdated Show resolved Hide resolved
@@ -7073,7 +7073,7 @@ Equip {1}</text>
<cmc>0</cmc>
<pt>1/1</pt>
</prop>
<set picURL="https://img.scryfall.com/cards/large/front/6/a/6aaa8539-8d21-4da1-8410-d4354078390f.jpg">AKH</set>
<set picURL="https://c1.scryfall.com/file/scryfall-cards/large/front/6/a/6aaa8539-8d21-4da1-8410-d4354078390f.jpg?1562844799">AKH</set>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been coming for a while but every single image that starts with img.scryfall is broken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #92

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it could be fixed with automation.

Change img to c1 and add in file/scryfall- after com/

As far as I can tell the ?number at the end of the link affects nothing, and the link works the same without it from what I can see.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have had one situation where the ? actually did affect the shown picture in scryfall over on the spoilers repo, the spoilers repo used to trim it but we reverted that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official info from Scryfall support is that they use the integer to bust the CND caches for various reasons.
One should use the URI they provide with the integer parameter at the end to ensure one gets the best version of the image currently available.

Not so sure that is super relevant for us as we cache pictures locally anyway and the client never realizes that a parameter got updated to redownload the file and update the local version.

@@ -7058,7 +7058,7 @@ Equip {1}</text>
<cmc>0</cmc>
<pt>1/1</pt>
</prop>
<set picURL="https://media-dominaria.cursecdn.com/attachments/113/426/635201279747658553.jpg">C13</set>
<set picURL="https://c1.scryfall.com/file/scryfall-cards/large/front/1/3/13e4832d-8530-4b85-b738-51d0c18f28ec.jpg?1630007268">C13</set>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a low quality scan, I think it's just the wizards token but upscaled

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all they have currently:
https://api.scryfall.com/cards/13e4832d-8530-4b85-b738-51d0c18f28ec

While being a bit bigger in resolution and way bigger in size... the png seems to be the same?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, after I've merged this, was this token actually printed in C13?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's printed in CC2 as far as I'm aware.

@ebbit1q ebbit1q merged commit 9441cca into Cockatrice:master May 9, 2022
@tooomm tooomm mentioned this pull request May 9, 2022
@mainman879 mainman879 deleted the patch-1 branch May 9, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ophiomancer's Snake Token Art
3 participants