Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails #746

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails #746

wants to merge 4 commits into from

Commits on Jun 27, 2023

  1. Being more specific while checking remote Cocoapods spec repo URL 

    Currently, the check to detect if the public Cocoapods spec repo is being used is a simple Regex match on github.com

This backfires when we use private instances in github.com to host the spec repo (As is the case at LinkedIn)

This patch makes the Regex more specific and only targets the public Cocoapods spec repo instance. The following two regex matches verify that claim:

HTTPS remote URL match: https://rubular.com/r/oIsVWngbVcPTGT
SSH remote URL match: https://rubular.com/r/HvnyKImgQptFU8
    @Buzz-Lightyear
    Buzz-Lightyear authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5ad4015 View commit details
    Browse the repository at this point in the history

  2. Keeping the regex /github.com/ for compatibility reasons

    @Buzz-Lightyear
    Buzz-Lightyear authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    4782579 View commit details
    Browse the repository at this point in the history

  3. If modified_since_commit fails, repo update should still continue

    @Buzz-Lightyear
    Buzz-Lightyear authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3478cb6 View commit details
    Browse the repository at this point in the history

  4. Typo in repo_id

    @Buzz-Lightyear
    Buzz-Lightyear authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    433fc6f View commit details
    Browse the repository at this point in the history