Use relative_path for local Swift packages #919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #911 added support for local packages but did not add support for the
relativePath
property inside of the local package definition. Here's a sample from my pbxproj file:When I try to use the new local package model I got the following error:
[!] Xcodeproj doesn't know about the following attributes {"relativePath"=>"../../Packages/SharedResources"} for the 'XCLocalSwiftPackageReference' isa.
and I believe that was because the class was looking forpath
(which doesn't exist) and notrelativePath
which does.This PR fixes that problem for local packages.