Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for builds broken by Xcode 16 #975

Closed
wants to merge 1 commit into from

Conversation

travis-mark
Copy link

I hope this format for the PR is okay, never contributed here before. I ran into this when our intern grouped the 3 files he was working on and broke builds. I rolled back the grouping in our project, but I wanted CocoaPods to be able to support it going forward.

Changes:

  • Add object version 70 to version map
  • Add support for new folder group type (PBXFileSystemSynchronizedRootGroup), currently an empty implementation to resolve error

Related Issues:

- Add object version 70 to version map
- Add support for new folder group type
@Brett-Best
Copy link
Contributor

You may be interested in #942 :)

@sborovikov-belkacar
Copy link

I’ve checked this fix locally on my Mac within Fastlane in a project with the new Xcode folders format. It's working!

@igor-makarov
Copy link
Contributor

@travis-mark I've looked at this PR, and while it fixes the crash, the underlying problem will not go away.

Since the FS-synchronized group is a new type with its own properties and child entities, Xcodeproj won't know how to output it. Which will cause the resulting project file to lose data.

I strongly recommend looking at #942 and perhaps helping out on it.

@amorde
Copy link
Member

amorde commented Oct 27, 2024

I've merged #985 which is a more complete implementation. Thanks!

@amorde amorde closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants