Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a plugin, cocoapods-dependency-graph #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sueLan
Copy link

@sueLan sueLan commented Oct 23, 2020

Add a plugin to help people know more about the relationship and version about the pod dependency.

@igor-makarov
Copy link
Contributor

Hi @sueLan!
I've tried to add your plugin and it's crashing out on missing requires. I've notices you haven't got the runtime dependencies defined in your .gemspec.

You add them like so:

  spec.add_dependency 'cocoapods'
  spec.add_dependency 'rgl'
  spec.add_dependency 'fast_excel'

This way, your Gemfile doesn't need to list the runtime deps at all and also the users will get them installed.

See my repo for a complete example: xcake.gemspec Gemfile.

@sueLan
Copy link
Author

sueLan commented Oct 28, 2020

spec.add_dependency 'cocoapods'
spec.add_dependency 'rgl'
spec.add_dependency 'fast_excel'

Hi, thanks a lot for this feedback. So nice! I have fixed it and tested this plugin in another MAC without rgl, `'fast_excel'.

@igor-makarov
Copy link
Contributor

Looks good now! I've tried it on my project and there seems to be a bug - I have 105 pods installed but the dep list output by the plugin is only 23. Could you check what happens when a project has multiple targets or nested abstract targets?

Anyway, this shouldn't probably block us from adding it. I'll ask for a second opinion now. @dnkoutso what do you think?

@sueLan
Copy link
Author

sueLan commented Nov 16, 2020

Looks good now! I've tried it on my project and there seems to be a bug - I have 105 pods installed but the dep list output by the plugin is only 23. Could you check what happens when a project has multiple targets or nested abstract targets?

Anyway, this shouldn't probably block us from adding it. I'll ask for a second opinion now. @dnkoutso what do you think?

Hi, sorry for the delay. Previously, I only generate the dependency graph for the first target in this project. Now I have supported multi-targets in this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants