-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed camel case? #60
Conversation
Pull Request Test Coverage Report for Build 1091798901
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1164376598
💛 - Coveralls |
Screenshots? Did you test this to make sure it doesn't break anything? |
should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem we had last time was that the form item would now contain no camel case. This would mean the request would come back bad request because the backend would be expecting camel case. If you are sure that you tested this thoroughly I will approve. If it is not tested it can and will break the whole form.
Yeah you're right it did break the form. I changed it so that it takes the enum and formats it to look nice so now everything should be good. I tested it and it works |
# Conflicts: # src/components/userDirectory/CreateUser.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost! Just one thing. Since you are using the function convertEnumToRegularText 3 times in 3 different files you should put it in utils folder and then import it when it needs to be used
Smart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick ⛏️ otherwise LGTM
@@ -19,6 +19,13 @@ export const getOptionsFromEnum = (e: { | |||
)); | |||
}; | |||
|
|||
export const convertEnumToRegularText = (input: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const convertEnumToRegularText = (input: string) => { | |
export const convertEnumToRegularText = (input: string): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why
Ticket
Ticket
This PR
Fixes camel case? Not sure if this is what the ticket meant