fix json + duped button #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huang0h
added a commit
that referenced
this pull request
Jul 2, 2024
* Added component for filter * Add skeleton component, params, api route to client, basic outline * Fix compilation errors * Fix site id * Add list view of image * Cannot read properties of undefined map * Start selection * Tested filter site images * Fix null * Cleanup * Add frontend implementation of approving and rejecting images * Address review comments * fix translation changes * Add loading functionality and clear filters functionality * working: translations + styling + tests * working: need to finalize design * tests + cleanup * tests * disable submit when no reason * initial value * remove usecallback + switch to dropdown * Fix so that the table works with no unapproved images * correct reject route * Added reason * Finished most of the visuals Finished most of the UI for the grid view and the modals * Finished approve/reject modal * Update protectedApiClient.ts * fix json + duped button (#364) * pr comments: message, select checkbox, dynamic styles * translations --------- Co-authored-by: SurabhiKeesara <surabhi.keesara@gmail> Co-authored-by: Avery Huang <[email protected]> Co-authored-by: Avery Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run checkyarn run testWhy
Resolves #
This PR
Screenshots
Verification Steps