-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#Ft: Migrate to sendGrid and Add notifications with Socket #40
base: develop
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://code-hills-pr-40.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co0o97v79t8c73f344t0. |
d900416
to
dc417f4
Compare
dc417f4
to
d542e00
Compare
b952614
to
82a9076
Compare
package.json
Outdated
@@ -42,6 +43,7 @@ | |||
"express": "^4.18.2", | |||
"express-fileupload": "^1.4.0", | |||
"express-session": "^1.17.3", | |||
"joi": "^17.12.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @leandreAlly , We can use Valibot instead of using 2 validation libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work on the comments otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…x Notification service class
06d419d
to
2050ec1
Compare
What does this PR do?
This PR is all about migrating our app email service from
nodemailer
tosendgrid
. and it contains the implementation of pushing notifications to client side every time there is an action which is performed by the help[ of socket.io .Description of Task to be completed?
this task allow the user to receive the notifications which only belong to him/her any time there an action performed which concerned to hi/her.
Those action we can mention the line being added to the project, and when their account being disabled.
Requirements
How should this be manually tested?
Update your .env
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: