Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Ft: Migrate to sendGrid and Add notifications with Socket #40

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

leandreAlly
Copy link
Contributor

@leandreAlly leandreAlly commented Mar 25, 2024

What does this PR do?

This PR is all about migrating our app email service from nodemailer to sendgrid. and it contains the implementation of pushing notifications to client side every time there is an action which is performed by the help[ of socket.io .

Description of Task to be completed?

this task allow the user to receive the notifications which only belong to him/her any time there an action performed which concerned to hi/her.

Those action we can mention the line being added to the project, and when their account being disabled.

Requirements

  • Require dependences installation
  • Require .env update
  • Documentation updated

How should this be manually tested?

  • Clone this repository
  • checkout to this branch ft-migrate-sendgrid
  • install the dependencies npm install and
  • Run migrations npm run db:migrate
  • Create some users or run seeds npm run db:seed and then start the server npm run dev
  • Go to http://localhost:$PORT/api/v1/docs in your browser to access the api documentation
  • Go to http://localhost:$PORT/api/v1/docs/notifications for querying all notifications in the app.
  • Go to http://localhost:$PORT/api/v1/docs/notifications/:id for mark notification as read.

Update your .env

SEND_GRID_EMAIL=
SENDGRID_API_KEY=

Any background context you want to provide?

  • You need the to have working sendgrid account to test this PR.

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

  • N/A

Copy link

render bot commented Mar 25, 2024

@leandreAlly leandreAlly self-assigned this Mar 25, 2024
@leandreAlly leandreAlly added the WIP This feature is still in progress label Mar 25, 2024
@leandreAlly leandreAlly force-pushed the ft-migrate-sendgrid branch 2 times, most recently from d900416 to dc417f4 Compare April 24, 2024 21:06
@leandreAlly leandreAlly force-pushed the ft-migrate-sendgrid branch from dc417f4 to d542e00 Compare May 29, 2024 11:33
@leandreAlly leandreAlly added Review needed Ready to merge This PR have been approved and it is ready to be merged and removed WIP This feature is still in progress labels Jun 5, 2024
@leandreAlly leandreAlly force-pushed the ft-migrate-sendgrid branch 2 times, most recently from b952614 to 82a9076 Compare June 11, 2024 17:47
package.json Outdated
@@ -42,6 +43,7 @@
"express": "^4.18.2",
"express-fileupload": "^1.4.0",
"express-session": "^1.17.3",
"joi": "^17.12.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leandreAlly , We can use Valibot instead of using 2 validation libraries

Copy link
Collaborator

@TresorRw TresorRw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on the comments otherwise LGTM

@leandreAlly leandreAlly requested a review from TresorRw June 19, 2024 17:51
Copy link
Collaborator

@TresorRw TresorRw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge This PR have been approved and it is ready to be merged Review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants