Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing ctrl, alt, win keys pressed down without any other key #160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bfritscher
Copy link
Contributor

  • Removed filtering of modifierkey to allow to handle them in ToInputs.
  • Filtered triggering of modifier display for modifierkeys themselves in
    ToInputs.
  • Exposed IsModifierKeyPress as static to be used in KeyPress and
    Messages.
  • KeyPress.HasModifierPress returns false if key is a modifierkey itself
    (allow the merging in Message).
  • Message disable repeat counting incrementing for modifierkeys
    themself, but still handling their repeat, in order for them to keep
    showing while keydown.

This should partially solve issue #154
Note sure about the sticky key part on mac.

@hnrkndrssn hnrkndrssn self-assigned this Jul 16, 2017
- Removed filtering of modifierkey to allow to handle them in ToInputs.
- Filtered triggering of modifier display for modifierkeys themselves in
ToInputs.
- Exposed IsModifierKeyPress as static to be used in KeyPress and
Messages.
- KeyPress.HasModifierPress returns false if key is a modifierkey itself
(allow the merging in Message).
- Removed merge flag in favor of handling the strategy directly in Message.MergeIfNeeded
@bfritscher bfritscher force-pushed the show-modifier-keys-while-down branch from ec1cd25 to c3e04a8 Compare July 17, 2017 10:42
@bfritscher
Copy link
Contributor Author

bfritscher commented Jul 17, 2017

after integrating it with my other changes i found there are bugs, and found another solution, but it now seems to fail the tests :-(

But a side effect is that it now support issue #76

@hnrkndrssn
Copy link
Contributor

Hey @bfritscher,

I haven't forgotten about your PRs, I've just been busy with some other things lately. I should have some time over the next week or so to sit down and review your PRs.

My apologies for the delay in getting to them!

Thanks,
henrik

@bfritscher
Copy link
Contributor Author

@alfhenrik No problems :-)
And I understand that they are a bit more complex. They also might need some test cases, in order to cover edge cases. Happy to do some changes after your insights.
Best regards,
Boris

@king3dward
Copy link

To solve this issue would be so helpful, to show CTRL SHIFT stand alone. Any progress maybe?

@clragon
Copy link

clragon commented Oct 12, 2019

I was looking to get a counter on the modifier keys specifically, but there seems no option to do so...

@Benbinbin
Copy link

  • Removed filtering of modifierkey to allow to handle them in ToInputs.
  • Filtered triggering of modifier display for modifierkeys themselves in
    ToInputs.
  • Exposed IsModifierKeyPress as static to be used in KeyPress and
    Messages.
  • KeyPress.HasModifierPress returns false if key is a modifierkey itself
    (allow the merging in Message).
  • Message disable repeat counting incrementing for modifierkeys
    themself, but still handling their repeat, in order for them to keep
    showing while keydown.

This should partially solve issue #154
Note sure about the sticky key part on mac.

Hi, @bfritscher I really appreciate your work to add the mouse highlight, but the https://github.com/bfritscher/carnac/tree/v3-beta seem have a bug, like #173 descripe, when hold two keys and left click, but it dosen't show any key just the mouse icon.

@crutchcorn
Copy link

Any possibility of getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants