PLDM file buffer sizes and pldm-file-host usability #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pldm-file-host example can now serve a synthetic 4GB file of zeroes, and also supports a --file argument. --offset can be used to create output with the offset included every 64 bytes, for debug purposes. Signed-off-by: Matt Johnston <[email protected]>
Signed-off-by: Matt Johnston <[email protected]>
Part size has a large effect on performance, so allow applications to provide a larger buffer. The buffer must match the size provided in multipart negotiation, otherwise messages will be dropped. Signed-off-by: Matt Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running with larger part sizes for better performance.
pldm-file-host has some extra functionality to run with synthetic data when measuring speed.