Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility area show/hide animates with push/pull rather than revealing #1778

Closed
wants to merge 2 commits into from

Conversation

FastestMolasses
Copy link
Member

Description

Similar to Xcode, the utility area will push or pull the content when collapsing, instead of just clipping through the content.

Related Issues

Closes #1635

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

utility.area.mov

@FastestMolasses FastestMolasses added enhancement New feature or request UI This is UI related labels Jun 25, 2024
@FastestMolasses FastestMolasses self-assigned this Jun 25, 2024
@FastestMolasses
Copy link
Member Author

There's a small lag between the tab bar and the content beneath it. I tried animation types like .default and .linear but they just end up snapping between positions. Only ones that work is ones like .smooth or .snappy. Anyone know how to make the content offset match more closely with the position of the tab bar?

@austincondiff
Copy link
Collaborator

austincondiff commented Jun 25, 2024

Very nice! Yeah, it’s like two animations are being applied, and the easing methods are not matching up. If you track through the video you can see it get farther away then get passed up.

Maybe check for additional animations you may have forgotten to remove?

@FastestMolasses
Copy link
Member Author

FastestMolasses commented Jun 25, 2024

Doesnt seem like any other animation is affecting it. Not sure what the issue is. It does look like it's an easing issue, but none of the other animation types work, so its really weird.

@austincondiff
Copy link
Collaborator

austincondiff commented Aug 16, 2024

Closing this PR as it has been fixed with #1845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI This is UI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Utility area show/hide animation should push/pull rather than reveal
2 participants