Fixed editor tabs from being non-interactive #2004
Merged
+33
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in a recent version of macOS. It seems like the topmost item loses interactivity so we fix this by placing a 1pt Rectangle at the top.
austincondiff
requested review from
thecoolwinter,
tom-ludwig,
0xWDG and
FastestMolasses
FastestMolasses
approved these changes
Mar 7, 2025
6 tasks
thecoolwinter
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a temporary fix for a bug introduced in the latest version of macOS. This should be periodically checked to see if it is fixed and when it is, revert this fix.
Description
Restored editor tabs interactivity. It seems like the topmost item loses interactivity so we fix this by placing a 1pt Rectangle at the top, effectively tricking the system. We then apply negative top padding inside to correct spacing issues.
Checklist