Skip to content

Trustlab: Enhance Hero component with responsive design, new button functionality, and SVG icon integration #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 18, 2025

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Aug 15, 2025

Description

This PR enhances Hero Component to match new designs

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Aug 15, 2025
@koechkevin koechkevin requested a review from a team August 15, 2025 11:48
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @koechkevin, just a few observations.

  1. We need to change the block image to match the new design
  2. When we have only one slide, perhaps we can hide the Next and Previous buttons instead of disabling them.
  3. When navigating to the next slide, there is a big delay before the content appears compared to navigating back. This causes the entire hero to just be "white"

Image

@koechkevin koechkevin requested a review from a team August 18, 2025 06:44
@kilemensi
Copy link
Member

Heita @koechkevin ... pulled this locally and image doesn't appear to be a required field. Is this correct?

Screenshot 2025-08-18 at 10 00 12

@koechkevin
Copy link
Contributor Author

Heita @koechkevin ... pulled this locally and image doesn't appear to be a required field. Is this correct?

Screenshot 2025-08-18 at 10 00 12

It should be required

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Running it locally:

  1. Reuse the current hero animation (i.e. those running at https://trustlab.dev.codeforafrica.org). The hero animation in this PR seem off to me.
  2. The hero is a bit too big to me. I can't see anything else on the screen on first page load.

Image

Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koechkevin koechkevin requested a review from kilemensi August 18, 2025 12:45
@kilemensi
Copy link
Member

If hero size is fixed @koechkevin, lets deploy this!

@koechkevin koechkevin added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit a37fe92 Aug 18, 2025
5 checks passed
@koechkevin koechkevin deleted the trustlab_hero_update branch August 18, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants