-
Notifications
You must be signed in to change notification settings - Fork 2
Trustlab: Enhance Hero component with responsive design, new button functionality, and SVG icon integration #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ionality, and SVG icon integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @koechkevin, just a few observations.
- We need to change the block image to match the new design
- When we have only one slide, perhaps we can hide the Next and Previous buttons instead of disabling them.
- When navigating to the next slide, there is a big delay before the content appears compared to navigating back. This causes the entire hero to just be "white"
Heita @koechkevin ... pulled this locally and image doesn't appear to be a required field. Is this correct? ![]() |
It should be required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Running it locally:
- Reuse the current hero animation (i.e. those running at https://trustlab.dev.codeforafrica.org). The hero animation in this PR seem off to me.
- The hero is a bit too big to me. I can't see anything else on the screen on first page load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If hero size is fixed @koechkevin, lets deploy this! |
Description
This PR enhances Hero Component to match new designs
Fixes # (issue)
Type of change
Screenshots
Checklist: