Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issues 195, 109, 166, 142, 188] - Unlink confirmation dialogs + Add role type to nav bar + Email facilities + Styling #198

Merged
merged 22 commits into from
Oct 15, 2020
Merged

[Issues 195, 109, 166, 142, 188] - Unlink confirmation dialogs + Add role type to nav bar + Email facilities + Styling #198

merged 22 commits into from
Oct 15, 2020

Conversation

ijadams
Copy link
Contributor

@ijadams ijadams commented Sep 24, 2020 •
edited
Loading

Related Issues

#195
#109
#166
#142
#188

Description

  • misc styling
  • global stylesheet
  • role type added to nav
  • unlinking validation and modal
  • Created a button to call send bulk emails modal (email modal form with a filter for various facility types - visible only for user and admin roles)
  • Created a single email contact button on contact table
  • Form validation on modal submits
  • Toast message for err/success
  • Download CSV functionality
  • Misc styling edits
  • Added jest for basic unit testing

Testing

npm run test

Related PRs

CodeForBaltimore/Bmore-Responsive#295

@ijadams ijadams changed the title [Issues 195, 109, 166, 142] - Unlink confirmation dialogs + Add role type to nav bar + Styling [Issues 195, 109, 166, 142, 188] - Unlink confirmation dialogs + Add role type to nav bar + Styling Sep 24, 2020
@ijadams ijadams changed the title [Issues 195, 109, 166, 142, 188] - Unlink confirmation dialogs + Add role type to nav bar + Styling [Issues 195, 109, 166, 142, 188] - Unlink confirmation dialogs + Add role type to nav bar + Email facilities + Styling Sep 24, 2020
@ijadams ijadams mentioned this pull request Sep 29, 2020
Closed
@ijadams ijadams mentioned this pull request Oct 9, 2020
Merged
@ijadams ijadams requested review from c-w-allen and stoopidJSON and removed request for c-w-allen October 9, 2020 14:25
@stoopidJSON stoopidJSON merged commit 4e96b36 into CodeForBaltimore:master Oct 15, 2020
@stoopidJSON
Copy link
Member

@all-contributors add @ijadams for code

@allcontributors allcontributors bot mentioned this pull request Oct 15, 2020
Merged
@allcontributors
Copy link
Contributor

@revjtanton

I've put up a pull request to add @ijadams! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoopidJSON stoopidJSON stoopidJSON approved these changes

@c-w-allen c-w-allen Awaiting requested review from c-w-allen

@funkybunch funkybunch Awaiting requested review from funkybunch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijadams @stoopidJSON