generated from CodeForBaltimore/ProjectTemplate
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmarklund10/ add home page testing; refactor home page component by breaking it out into separate modules #278
Merged
blakenan-bellese
merged 28 commits into
CodeForBaltimore:master
from
nmarklund10:nmarklund10/275-test-suite
Mar 31, 2022
Merged
nmarklund10/ add home page testing; refactor home page component by breaking it out into separate modules #278
blakenan-bellese
merged 28 commits into
CodeForBaltimore:master
from
nmarklund10:nmarklund10/275-test-suite
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes names to specify login specific elements
blakenan-bellese
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the tests and the proactive refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented initial testing of the Home page or where the user logins. There are 7 tests:
As I was building the tests, I noticed that there were opportunities to break out the component into smaller modules to prevent the messy code with showing alerts and the modal.
Related Issues
List related Issues:
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
npm test
Impacted Areas in Application
List general components of the application that this PR will affect: